Skip to content

Update Ruby docs sample to latest Ruby 3.4 version #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

srinjoyray
Copy link

Description

Update docs sample for GAE Standard, GAE Flex, Cloud Run and Cloud Run Functions to latest Ruby 3.4 version

Checklist

  • Tests pass
  • Lint pass: bundle exec rubocop
  • Please merge this PR for me once it is approved.

@srinjoyray srinjoyray requested review from a team as code owners May 12, 2025 05:14
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 12, 2025
@dazuma dazuma added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2025
@@ -19,9 +19,12 @@ gem "sinatra"
gem "webrick", "~> 1.8"

# [END gae_flex_quickstart_dependencies]
ruby "~>3.2"
ruby "~>3.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a flexible runtime for Ruby 3.4? I was under the impression that the runtimes transitioned to the app engine standard platform some time ago. (I don't see a Ruby version update in https://github.com/GoogleCloudPlatform/ruby-docker for example.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do release new runtimes to both GAE Flex and Standard - https://cloud.google.com/appengine/docs/flexible/lifecycle/support-schedule#ruby

I'm not aware about https://github.com/GoogleCloudPlatform/ruby-docker
I see it is not an actively maintained repo.

As part of runtime release for Ruby 3.4, we are required to update the ruby-docs-sample apps which are mentioned in the quickstart sample to use the latest runtime.

@srinjoyray srinjoyray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants